Skip to content

Support for trait mapping files #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support for trait mapping files #224

wants to merge 1 commit into from

Conversation

@bigfoot90
Copy link

Solve #223

@bigfoot90 bigfoot90 mentioned this pull request Jan 6, 2022
Open
greg0ire
greg0ire reviewed Jan 6, 2022
View reviewed changes
lib/Doctrine/Persistence/Mapping/RuntimeReflectionService.php
}

$parents = class_parents($class);
$parents = class_parents($class) + class_uses($class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a violation of this method's signature:

persistence/lib/Doctrine/Persistence/Mapping/ReflectionService.php

Line 23 in 9f22673

* @psalm-return class-string[]

Also, it's inconsistent with its name.

@bigfoot90
Copy link
Author

The schema tool is working rigth now with traits and xml mappings.

But the UnitOfWork is not, I need a help here.

I'm getting this error:
[ReflectionException] Given object is not an instance of the class this property was declared in

#1  /var/www/symfony/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php:656
#2  /var/www/symfony/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php:514
#3  /var/www/symfony/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php:834
#4  /var/www/symfony/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php:355
#5  /var/www/symfony/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:388
#6  /var/www/symfony/var/cache/test/ContainerSPzjQBW/EntityManager_9a5be93.php:136
#7  /var/www/symfony/vendor/theofidry/alice-data-fixtures/src/Bridge/Doctrine/Persister/ObjectManagerPersister.php:95
#8  /var/www/symfony/var/cache/test/ContainerSPzjQBW/ObjectManagerPersister_eccc052.php:39
#9  /var/www/symfony/vendor/theofidry/alice-data-fixtures/src/Loader/PersisterLoader.php:93
#10 /var/www/symfony/var/cache/test/ContainerSPzjQBW/PersisterLoader_c8a8e24.php:39

@derrabus
Copy link
Member

derrabus commented Jan 6, 2022 •
edited
Loading

  • Please target the 2.3.x 2.4.x branch because this is a new feature.
  • Please add tests.

@derrabus derrabus added the Enhancement New feature or request label Jan 6, 2022
@greg0ire greg0ire mentioned this pull request Jan 8, 2022
Closed
@derrabus derrabus changed the base branch from 2.2.x to 2.4.x January 9, 2022 21:27
@greg0ire greg0ire deleted the branch doctrine:2.4.x October 14, 2025 19:43
@greg0ire greg0ire closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire left review comments

Assignees

No one assigned

Labels

Enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigfoot90 @derrabus @greg0ire